[ApplicationInsights] removing env var reads from hot path#1996
Merged
[ApplicationInsights] removing env var reads from hot path#1996
Conversation
kshyju
reviewed
Oct 30, 2023
kshyju
approved these changes
Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1827
During the (long) investigation into the issue above we have found that in some cases environment variable reads can be very expensive in App Service. But we cannot fully cache the variables because during certain App Service events (slot swaps, for example), the environment variables can change out from underneath us.
This change adds a background monitor to watch for the changes in these few environment variables, then triggers an Options change when it occurs. This keeps the expensive reads off the hot path.
Pull request checklist
release_notes.md